feat(gcs): support filename prefix filtering in listContents#1880
Open
mouize wants to merge 3 commits intothephpleague:3.xfrom
Open
feat(gcs): support filename prefix filtering in listContents#1880mouize wants to merge 3 commits intothephpleague:3.xfrom
mouize wants to merge 3 commits intothephpleague:3.xfrom
Conversation
Member
|
Hi, this would be a breaking change on the behavioural contract so will not be merged as it. What is possible, is to add a |
Author
Right ! Thx for the review. Just pushed a new update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for arbitrary filename prefix filtering to the GoogleCloudStorageAdapter::listContents() method.
Currently, the adapter forces a trailing / on the prefix, which prevents listing objects by filename prefix.
Ex: my_folder/my_file_prefixes_
This PR removes the forced /, allowing both directory and filename prefix listing as supported by Google Cloud Storage natively.
Why
• GCS natively supports prefix filtering server-side.
• Current adapter prevents efficient listing of large buckets by filename prefix.
• This makes Flysystem closer to native GCS behavior.
Fixes #1879